[C/C++] Install a CMake package configuration file #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin4861
approved these changes
Nov 10, 2025
Contributor
martin4861
left a comment
martin4861
left a comment
There was a problem hiding this comment.
Hi @ethanmusser , thank you for contributing 🚀 Could you also update the test package in c/test_package/CMakeLists.txt please, so that it uses find_package(libsbp REQUIRED) instead of find_library and then link the libraries against swiftnav::sbp?
Contributor
Author
@martin4861 No problem, thanks for checking it out! I updated the |
ethanmusser
deleted the
ethanmusser/feat/1528-cmake-add-package-configuration
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
Install a CMake package configuration file.
This change permits downstream users configuring with CMake to include the SBP C bindings in their project as follows.
Currently, those same consumers need to create a custom
Findlibsbp.cmakefind module script.API compatibility
Does this change introduce a API compatibility risk?
No. This change simply adds to the installed files. The previous
sbp-exporttarget build tree export is preserved.API compatibility plan
N/A
JIRA Reference
N/A
However, resolves #1528.